Stream: git-wasmtime

Topic: wasmtime / PR #8524 cranelift: Rewrite operands with allo...

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 00:15):

jameysharp requested elliottt for a review on PR #8524.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 00:15):

jameysharp opened PR #8524 from jameysharp:unify-operand-visitors to bytecodealliance:main:

This makes all other code that uses AllocationConsumer into no-ops because the list of allocations in all other places are now always empty.

There is a bunch of dead code still left over after this. This part is just the stuff I can delete without changing function signatures everywhere. The various functions which are now no-ops are called in a lot of places and cleaning those up will take more careful review.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 00:15):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8524.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2024 at 00:48):

jameysharp commented on PR #8524:

Instead of reusing AllocationConsumer as the new implementer of OperandVisitor, I wonder if I should provide an OperandVistor implementation for FnMut and just use a closure before do_emit. Then the future PR that deletes the remaining dead code here will completely delete AllocationConsumer as well.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2024 at 01:47):

jameysharp updated PR #8524.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2024 at 02:22):

jameysharp updated PR #8524.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2024 at 23:40):

elliottt submitted PR review:

This is awesome! Really looking forward to seeing the follow up prs that remove all that dead code :D

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2024 at 01:08):

jameysharp merged PR #8524.

Last updated: Dec 23 2024 at 13:07 UTC