Stream: git-wasmtime

Topic: wasmtime / PR #8519 wasi-nn: remove Git submodule


view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 16:50):

abrown opened PR #8519 from abrown:wasi-nn-submodule to bytecodealliance:main:

To more closely align with the conventions in the wasmtime-wasi and wasmtime-wasi-http crates, this change removes the Git submodule that previously provided the WIT and WITX files for wasmtime-wasi-nn. Like those other crates, the syncing of wasi-nn WIT and WITX files will happen manually for the time being. This is the first PR towards upgrading the wasi-nn implementation to match recent spec changes and better preview2-ABI compatibility.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 16:50):

abrown requested alexcrichton for a review on PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 16:50):

abrown requested wasmtime-core-reviewers for a review on PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 16:50):

abrown requested wasmtime-default-reviewers for a review on PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 16:50):

abrown updated PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 17:38):

alexcrichton commented on PR #8519:

Could you update this script to additionally vendor this WIT? That way we ideally have a single knob to flip to update when necessary and CI checks that we're matching upstream.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 18:06):

abrown updated PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 18:08):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 18:08):

abrown has enabled auto merge for PR #8519.

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 18:52):

abrown merged PR #8519.


Last updated: Dec 23 2024 at 13:07 UTC