Wasmtime GitHub notifications bot (May 01 2024 at 16:50): Wasmtime GitHub notifications bot (May 01 2024 at 16:50):abrown opened PR #8519 from abrown:wasi-nn-submodule to bytecodealliance:main:
To more closely align with the conventions in the
wasmtime-wasiandwasmtime-wasi-httpcrates, this change removes the Git submodule that previously provided the WIT and WITX files forwasmtime-wasi-nn. Like those other crates, the syncing of wasi-nn WIT and WITX files will happen manually for the time being. This is the first PR towards upgrading the wasi-nn implementation to match recent spec changes and better preview2-ABI compatibility.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 01 2024 at 16:50):abrown requested alexcrichton for a review on PR #8519.
Wasmtime GitHub notifications bot (May 01 2024 at 16:50):abrown requested wasmtime-core-reviewers for a review on PR #8519.
Wasmtime GitHub notifications bot (May 01 2024 at 16:50):abrown requested wasmtime-default-reviewers for a review on PR #8519.
Wasmtime GitHub notifications bot (May 01 2024 at 16:50):abrown updated PR #8519.
Wasmtime GitHub notifications bot (May 02 2024 at 17:38):alexcrichton commented on PR #8519:
Could you update this script to additionally vendor this WIT? That way we ideally have a single knob to flip to update when necessary and CI checks that we're matching upstream.
Wasmtime GitHub notifications bot (May 02 2024 at 18:06):abrown updated PR #8519.
Wasmtime GitHub notifications bot (May 02 2024 at 18:08):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 02 2024 at 18:08):abrown has enabled auto merge for PR #8519.
Wasmtime GitHub notifications bot (May 02 2024 at 18:52):abrown merged PR #8519.
Last updated: Oct 23 2024 at 20:03 UTC