Stream: git-wasmtime

Topic: wasmtime / PR #8518 Reassociate mixture of add and sub to...


view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 15:34):

KGrewal1 requested abrown for a review on PR #8518.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 15:34):

KGrewal1 opened PR #8518 from KGrewal1:assoc-add-sub to bytecodealliance:main:

As in https://github.com/bytecodealliance/wasmtime/pull/7466 , converts deep nesting of addition and subtraction into a wide tree eg:

$((a-b)-c)-d)=(a-b)-(c+d)$

again using subsume to prevent blow up due to reassociating large chains

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 15:34):

KGrewal1 requested wasmtime-compiler-reviewers for a review on PR #8518.

view this post on Zulip Wasmtime GitHub notifications bot (May 01 2024 at 17:44):

github-actions[bot] commented on PR #8518:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 01:40):

abrown submitted PR review:

Looks fine to me but does anyone with ISLE conventions paged in want to comment: @cfallin, @elliottt, @jameysharp?

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 14:50):

fitzgen submitted PR review:

LGTM! Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 15:13):

fitzgen commented on PR #8518:

(Some network issue when installing open-vino in CI; retrying)

view this post on Zulip Wasmtime GitHub notifications bot (May 02 2024 at 15:54):

fitzgen merged PR #8518.


Last updated: Dec 23 2024 at 12:05 UTC