KGrewal1 requested abrown for a review on PR #8518.
KGrewal1 opened PR #8518 from KGrewal1:assoc-add-sub
to bytecodealliance:main
:
As in https://github.com/bytecodealliance/wasmtime/pull/7466 , converts deep nesting of addition and subtraction into a wide tree eg:
$((a-b)-c)-d)=(a-b)-(c+d)$
again using subsume to prevent blow up due to reassociating large chains
KGrewal1 requested wasmtime-compiler-reviewers for a review on PR #8518.
github-actions[bot] commented on PR #8518:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
abrown submitted PR review:
Looks fine to me but does anyone with ISLE conventions paged in want to comment: @cfallin, @elliottt, @jameysharp?
fitzgen submitted PR review:
LGTM! Thanks!
fitzgen commented on PR #8518:
(Some network issue when installing open-vino in CI; retrying)
fitzgen merged PR #8518.
Last updated: Nov 22 2024 at 16:03 UTC