Stream: git-wasmtime

Topic: wasmtime / PR #8501 Use `wasmtime-runtime` as `crate::run...

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:05):

fitzgen requested alexcrichton for a review on PR #8501.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:05):

fitzgen requested wasmtime-core-reviewers for a review on PR #8501.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:05):

fitzgen requested wasmtime-default-reviewers for a review on PR #8501.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:05):

fitzgen opened PR #8501 from fitzgen:wasmtime-runtime-as-vm to bytecodealliance:main:

This is the first step towards merging these crates together.

We want to merge them together because there is no abstraction or layering or boundary between them in practice, but our architectures and designs have, at times, been constrained by this artificial crate boundary and what is visible in which crate and this has forced us to use nasty workarounds like defining traits in wasmtime-runtime that get implemented in wasmtime and used as dynamic trait objects inside wasmtime-runtime. Merging them will allow us to remove these hacks.

The next step after this, before actually merging the crates together, is to factor out wasmtime_runtime::{sys,mmap,mmap_vec} into its own crate, since this functionality is used directly by the CLI in one place, and I don't want to add that stuff to the wasmtime crate's public API.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:45):

github-actions[bot] commented on PR #8501:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:49):

fitzgen commented on PR #8501:

The next step after this, before actually merging the crates together, is to factor out wasmtime_runtime::{sys,mmap,mmap_vec} into its own crate, since this functionality is used directly by the CLI in one place, and I don't want to add that stuff to the wasmtime crate's public API.

This is proving to be a bit hairier than anticipated; investigating alternatives. Shouldn't affect this PR.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:56):

fitzgen updated PR #8501.

Wasmtime GitHub notifications bot (Apr 29 2024 at 17:23):

fitzgen updated PR #8501.

Last updated: Nov 22 2024 at 17:03 UTC