Wasmtime GitHub notifications bot (Apr 27 2024 at 22:59): Wasmtime GitHub notifications bot (Apr 27 2024 at 22:59):jameysharp requested fitzgen for a review on PR #8499.
Wasmtime GitHub notifications bot (Apr 27 2024 at 22:59):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8499.
Wasmtime GitHub notifications bot (Apr 27 2024 at 22:59):jameysharp opened PR #8499 from jameysharp:operand-visitor-trait to bytecodealliance:main:
This paves the way for more implementations of this OperandVisitor trait which can do different things with the operands.
Of particular note, this commit introduces a second implementation which is used only in the s390x backend and only to implement a debug assertion. Previously, s390x used an OperandCollector::no_reuse_def method to implement this assertion, but I didn't want to require that all implementors of the new trait have to provide that method, so this captures the same check but keeps it local to where it's needed.
Wasmtime GitHub notifications bot (Apr 29 2024 at 15:15):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Apr 29 2024 at 15:38):fitzgen merged PR #8499.
Last updated: Nov 22 2024 at 17:03 UTC