Stream: git-wasmtime

Topic: wasmtime / PR #8497 fix(c-api): give a cleaner error mess...

Wasmtime GitHub notifications bot (Apr 27 2024 at 13:41):

dundargoc requested wasmtime-core-reviewers for a review on PR #8497.

Wasmtime GitHub notifications bot (Apr 27 2024 at 13:41):

dundargoc requested fitzgen for a review on PR #8497.

Wasmtime GitHub notifications bot (Apr 27 2024 at 13:41):

dundargoc opened PR #8497 from dundargoc:fix/error_message to bytecodealliance:main:

Instead of

Performing build step for
'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an internal or external command, operable program or batch file.

this will now instead output

"cargo" was not found. Aborting...

Wasmtime GitHub notifications bot (Apr 29 2024 at 05:18):

rockwotj submitted PR review.

Wasmtime GitHub notifications bot (Apr 29 2024 at 05:18):

rockwotj created PR review comment:

Might be worth also recommending a resolution such as adding cargo to PATH or to CMAKE_PROGRAM_PATH.

Wasmtime GitHub notifications bot (Apr 29 2024 at 10:58):

dundargoc updated PR #8497.

Wasmtime GitHub notifications bot (Apr 29 2024 at 10:58):

dundargoc edited PR #8497:

Instead of

Performing build step for
'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an
internal or external command, operable program or batch file.

this will now instead output

"cargo" was not found. Ensure "cargo" is in PATH. Aborting...

Wasmtime GitHub notifications bot (Apr 29 2024 at 11:00):

dundargoc submitted PR review.

Wasmtime GitHub notifications bot (Apr 29 2024 at 11:00):

dundargoc created PR review comment:

Updated the warning to mention PATH. Skipped CMAKE_PROGRAM_PATH as I suspect PATH is easier and more straightforward for most users to use.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:16):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 29 2024 at 15:38):

fitzgen merged PR #8497.

Last updated: Nov 22 2024 at 16:03 UTC