dundargoc requested wasmtime-core-reviewers for a review on PR #8497.
dundargoc requested fitzgen for a review on PR #8497.
dundargoc opened PR #8497 from dundargoc:fix/error_message
to bytecodealliance:main
:
Instead of
Performing build step for
'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an internal or external command, operable program or batch file.this will now instead output
"cargo" was not found. Aborting...
rockwotj submitted PR review.
rockwotj created PR review comment:
Might be worth also recommending a resolution such as adding cargo to PATH or to CMAKE_PROGRAM_PATH.
dundargoc updated PR #8497.
dundargoc edited PR #8497:
Instead of
Performing build step for
'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an
internal or external command, operable program or batch file.this will now instead output
"cargo" was not found. Ensure "cargo" is in PATH. Aborting...
dundargoc submitted PR review.
dundargoc created PR review comment:
Updated the warning to mention PATH. Skipped CMAKE_PROGRAM_PATH as I suspect PATH is easier and more straightforward for most users to use.
fitzgen submitted PR review.
fitzgen merged PR #8497.
Last updated: Dec 23 2024 at 13:07 UTC