Stream: git-wasmtime

Topic: wasmtime / PR #8494 cranelift/riscv64: Fix `mv` instructi...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 07:41):

jameysharp requested afonso360 for a review on PR #8494.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 07:41):

jameysharp requested abrown for a review on PR #8494.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 07:41):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8494.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 07:41):

jameysharp opened PR #8494 from jameysharp:riscv-fix-mv to bytecodealliance:main:

The operand collector and the instruction emitter for Inst::Mov both placed the rm register before rd, so the emitted code was correct, but the pretty-printer used the opposite order and so printed the operands backwards. Note that the VCode disassembly disagreed with Capstone's disassembly of the emitted machine code.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 10:20):

afonso360 submitted PR review:

Neat, thanks for catching this!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 10:42):

afonso360 merged PR #8494.

Last updated: Dec 23 2024 at 12:05 UTC