Stream: git-wasmtime

Topic: wasmtime / PR #8490 build: make the c-api CMakeLists.txt ...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 11:03):

dundargoc opened PR #8490 from dundargoc:c-api/cmake to bytecodealliance:main:

Currently the CMakeLists.txt is designed to only be consumed by a parent project, which limits its flexibility. Adding a project() function allows it to also be built as its own project.

Also set USES_TERMINAL_BUILD to TRUE in ExternalProject_Add(), which allows getting the installation progress output from cargo build.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 11:03):

dundargoc requested fitzgen for a review on PR #8490.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 11:03):

dundargoc requested wasmtime-core-reviewers for a review on PR #8490.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 12:01):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 12:24):

alexcrichton merged PR #8490.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 22:52):

dundargoc commented on PR #8490:

Would it be fine to backport this to the release-20.0.0 branch? I don't mind sending another PR to that branch.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 27 2024 at 11:11):

dundargoc deleted a comment on PR #8490:

Would it be fine to backport this to the release-20.0.0 branch? I don't mind sending another PR to that branch.

Last updated: Nov 22 2024 at 16:03 UTC