Stream: git-wasmtime

Topic: wasmtime / PR #8487 Disable Criterion's "plotters" feature

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 07:13):

jameysharp requested cfallin for a review on PR #8487.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 07:13):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8487.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 07:13):

jameysharp requested wasmtime-default-reviewers for a review on PR #8487.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 07:13):

jameysharp opened PR #8487 from jameysharp:cut-criterion-deps to bytecodealliance:main:

This removes about a million lines from our estimated audit backlog according to cargo vet suggest.

If I understand the Criterion documentation correctly, I believe this means that generating HTML reports from Criterion benchmarks now requires having gnuplot installed, because it can't fall back to using the pure-Rust "plotters" crate.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 11:39):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 12:02):

alexcrichton merged PR #8487.

Last updated: Nov 22 2024 at 16:03 UTC