Stream: git-wasmtime

Topic: wasmtime / PR #8486 cranelift: Update operand aliases in-...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 05:41):

jameysharp opened PR #8486 from jameysharp:operand-collector-by-ref to bytecodealliance:main:

Now all registers passed to the operand collector are mutably borrowed directly out of their original locations in the Inst, so it is possible to update them in place.

As an initial demonstration of the utility of this change, the results of the VReg renamer are applied directly to the instructions during operand collection, and then all VReg aliases are cleared after operand collection.

Most of this commit consists of deleting noise from the many get_operands implementations in all the backends: most ampersands and asterisks, and all uses of the ref keyword.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 05:41):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8486.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 05:41):

jameysharp requested fitzgen for a review on PR #8486.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 16:33):

fitzgen submitted PR review:

Very nice!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 16:56):

fitzgen merged PR #8486.

Last updated: Dec 23 2024 at 12:05 UTC