Stream: git-wasmtime

Topic: wasmtime / PR #8484 Gate type-builder types from `wasmtim...

Wasmtime GitHub notifications bot (Apr 26 2024 at 00:02):

alexcrichton requested fitzgen for a review on PR #8484.

Wasmtime GitHub notifications bot (Apr 26 2024 at 00:02):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8484.

Wasmtime GitHub notifications bot (Apr 26 2024 at 00:02):

alexcrichton opened PR #8484 from alexcrichton:gate-env-type-builders to bytecodealliance:main:

This commit gates the *Builder types related to building sets of types in the wasmtime-environ crate on the compile feature. This helps bring in less code when the feature is disabled and helps exclude some dependencies for the upcoming no_std migration as well.

This commit doesn't change anything, it's just moving code around.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 26 2024 at 00:44):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 26 2024 at 13:49):

alexcrichton updated PR #8484.

Wasmtime GitHub notifications bot (Apr 26 2024 at 13:49):

alexcrichton has enabled auto merge for PR #8484.

Wasmtime GitHub notifications bot (Apr 26 2024 at 14:35):

alexcrichton merged PR #8484.

Last updated: Oct 23 2024 at 20:03 UTC