Stream: git-wasmtime

Topic: wasmtime / PR #8479 cranelift: Only set VReg type once

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 21:29):

jameysharp opened PR #8479 from jameysharp:set-vreg-type-once to bytecodealliance:main:

We know the type of each VReg at the moment when we allocate it, so we never need to set the type again. That also means we don't need to deduplicate reftyped VRegs as we go, although it's still possible to have duplicates after aliases are resolved.

This PR and #8469 remove the only two uses of FxHashSet in vcode.rs, so whichever one lands second needs to also delete the use item for that type or it'll introduce a new unused-import warning.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 21:29):

jameysharp requested elliottt for a review on PR #8479.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 21:29):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8479.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 03:06):

jameysharp updated PR #8479.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 03:07):

jameysharp commented on PR #8479:

Since #8469 landed I've rebased this PR.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 19:09):

elliottt submitted PR review:

Awesome!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 20:42):

jameysharp merged PR #8479.

Last updated: Nov 22 2024 at 16:03 UTC