Stream: git-wasmtime

Topic: wasmtime / PR #8469 cranelift: Simplify computing the clo...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 03:40):

jameysharp requested elliottt for a review on PR #8469.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 03:40):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8469.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 03:40):

jameysharp opened PR #8469 from jameysharp:compact-clobbers to bytecodealliance:main:

We have a perfectly good data structure for holding sets of physical registers. We don't need a hash-set to determine whether we already added a register to an array when we can just add it to a PRegSet and then extract a suitable array out of that.

This change also makes the computed array sorted, which isn't particularly important since the backends all modify it and then sort it again, but is generally a nice property to have.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 23:24):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 23:47):

fitzgen merged PR #8469.

Last updated: Nov 22 2024 at 16:03 UTC