Stream: git-wasmtime

Topic: wasmtime / PR #8464 cranelift: Don't resolve VReg aliases...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 20:55):

jameysharp requested abrown for a review on PR #8464.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 20:55):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8464.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 20:55):

jameysharp opened PR #8464 from jameysharp:no-aliases-in-lower to bytecodealliance:main:

When lower_branch_blockparam_args is called, the instructions which define the values used as blockparam args haven't been lowered yet, so we haven't set any aliases referring to them yet, so there's no point checking.

Note that block-param argument aliases are currently resolved after operand collection, so this work does happen eventually.

Also, this method doesn't add any instructions to self.ir_insts, so there's no need to call finish_ir_inst.

With this change, VReg alias resolution is purely local to vcode.rs.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 23:30):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 25 2024 at 23:53):

abrown merged PR #8464.

Last updated: Nov 22 2024 at 16:03 UTC