Wasmtime GitHub notifications bot (Apr 24 2024 at 11:59): Wasmtime GitHub notifications bot (Apr 24 2024 at 11:59):saulecabrera requested fitzgen for a review on PR #8460.
Wasmtime GitHub notifications bot (Apr 24 2024 at 11:59):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8460.
Wasmtime GitHub notifications bot (Apr 24 2024 at 11:59):saulecabrera requested wasmtime-core-reviewers for a review on PR #8460.
Wasmtime GitHub notifications bot (Apr 24 2024 at 11:59):saulecabrera opened PR #8460 from saulecabrera:winch-use-fmove32 to bytecodealliance:main:
This commit is a follow-up to https://github.com/bytecodealliance/wasmtime/pull/8365/. In https://github.com/bytecodealliance/wasmtime/pull/8453 single precision fmov was introduced in Cranelift, so now we can make use that instruction in Winch.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2024 at 12:00):saulecabrera edited PR #8460:
This commit is a follow-up to https://github.com/bytecodealliance/wasmtime/pull/8365/. In https://github.com/bytecodealliance/wasmtime/pull/8453 single precision fmov was introduced in Cranelift, so now we can make use of that instruction in Winch.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 24 2024 at 12:07):saulecabrera updated PR #8460.
Wasmtime GitHub notifications bot (Apr 24 2024 at 13:44):github-actions[bot] commented on PR #8460:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 24 2024 at 15:19):fitzgen submitted PR review:
\o/
Wasmtime GitHub notifications bot (Apr 24 2024 at 15:51):saulecabrera merged PR #8460.
Last updated: Oct 23 2024 at 20:03 UTC