Stream: git-wasmtime

Topic: wasmtime / PR #8454 cranelift/riscv64: Idiomatic AMode op...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 02:35):

jameysharp opened PR #8454 from jameysharp:riscv64-amode-idioms to bytecodealliance:main:

Other backends have functions for passing any registers in an AMode to the operand collector. Use the same pattern in this backend too: it's simpler to use, and also sets up for more changes I'm planning.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 02:35):

jameysharp requested cfallin for a review on PR #8454.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 02:35):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8454.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 03:19):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 03:19):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 03:19):

cfallin created PR review comment:

pre-existing typo but: s/that known/that are known/? or actually maybe refactor the sentence a bit e.g. "Provides operands within this AMode to the register allocator's operand collector."

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 04:02):

jameysharp updated PR #8454.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 04:03):

jameysharp has enabled auto merge for PR #8454.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 04:59):

jameysharp merged PR #8454.


Last updated: Dec 23 2024 at 12:05 UTC