Stream: git-wasmtime

Topic: wasmtime / PR #8453 cranelift(aarch64): Add single precis...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 00:38):

saulecabrera opened PR #8453 from saulecabrera:cranelift-aarch64-add-fpu-move32 to bytecodealliance:main:

This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/8365/files#r1565962730, to enable emission of 32-bit fmov from Winch.

I opted to introduce a new instruction over refactoring the existing FpuMov64 to be more generic to keep things simple, but I'm definitely open to exploring a refactoring if that's preferred.

Encoding reference: https://developer.arm.com/documentation/ddi0602/2024-03/SIMD-FP-Instructions/FMOV--register---Floating-point-Move-register-without-conversion-?lang=en

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 00:38):

saulecabrera requested elliottt for a review on PR #8453.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 00:38):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8453.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 00:39):

saulecabrera requested cfallin for a review on PR #8453.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 02:25):

cfallin submitted PR review:

LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2024 at 02:55):

cfallin merged PR #8453.


Last updated: Dec 23 2024 at 12:05 UTC