Wasmtime GitHub notifications bot (Apr 24 2024 at 00:07): Wasmtime GitHub notifications bot (Apr 24 2024 at 00:07):jameysharp requested fitzgen for a review on PR #8452.
Wasmtime GitHub notifications bot (Apr 24 2024 at 00:07):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8452.
Wasmtime GitHub notifications bot (Apr 24 2024 at 00:07):jameysharp opened PR #8452 from jameysharp:x64-borrow-imm8reg to bytecodealliance:main:
A minor cleanup setting up for a larger PR later.
Wasmtime GitHub notifications bot (Apr 24 2024 at 01:03):github-actions[bot] commented on PR #8452:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 24 2024 at 14:48):cfallin submitted PR review:
Reasonable cleanup; would have also taken "make more things
Copy" as a valid path to avoid the clones, probably it's all the same if the accessors are inlined though!
Wasmtime GitHub notifications bot (Apr 24 2024 at 15:17):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 24 2024 at 15:40):jameysharp commented on PR #8452:
would have also taken "make more things
Copy" as a valid path to avoid the clonesI actually want the borrows for later. :grin:
Wasmtime GitHub notifications bot (Apr 24 2024 at 16:08):jameysharp merged PR #8452.
Last updated: Dec 23 2024 at 13:07 UTC