Stream: git-wasmtime

Topic: wasmtime / PR #8447 winch: Handle -W tail-call


view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:11):

saulecabrera requested alexcrichton for a review on PR #8447.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:11):

saulecabrera requested wasmtime-core-reviewers for a review on PR #8447.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:11):

saulecabrera opened PR #8447 from saulecabrera:winch-detect-tail-calls to bytecodealliance:main:

Fixes https://github.com/bytecodealliance/wasmtime/issues/8446

The WebAssembly tail call proposal is currently not supported in Winch. This commit returns an error when trying to enable the tail call proposal while using Winch as the compiler.

Even though the issue linked above doesn't make use of any of the tail instructions, the trampolines were generated using Cranelift's tail call calling convention.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:12):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:12):

alexcrichton has enabled auto merge for PR #8447.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 19:44):

github-actions[bot] commented on PR #8447:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 20:10):

alexcrichton commented on PR #8447:

The hosted runner encountered an error while running your job. (Error Type: Disconnect).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 20:42):

alexcrichton commented on PR #8447:

Not a failure I've seen before...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 21:14):

alexcrichton merged PR #8447.


Last updated: Dec 23 2024 at 12:05 UTC