Wasmtime GitHub notifications bot (Apr 22 2024 at 16:41): Wasmtime GitHub notifications bot (Apr 22 2024 at 16:41):alexcrichton opened PR #8434 from alexcrichton:fix-panic to bytecodealliance:main:
This commit fixes a panic when a host function defined with
Func::newreturned GC references and was called in async mode. The logic to auto-gc before the return values go to wasm asserted that a synchronous GC was possible but the context this function is called in could be either async or sync. The fix applied in this commit is to remove the auto-gc. This means that hosts will need to explicitly GC in these situations until auto-gc is re-added back to Wasmtime.cc #8433 as this will make the behavior consistent, but we'll want to re-add the gc behavior.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 22 2024 at 16:41):alexcrichton requested fitzgen for a review on PR #8434.
Wasmtime GitHub notifications bot (Apr 22 2024 at 16:41):alexcrichton requested wasmtime-core-reviewers for a review on PR #8434.
Wasmtime GitHub notifications bot (Apr 22 2024 at 16:42):alexcrichton commented on PR #8434:
I'll also note that I plan on backporting this to the 20.0.0 release to happen today too.
Wasmtime GitHub notifications bot (Apr 22 2024 at 19:24):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 22 2024 at 19:49):fitzgen merged PR #8434.
Last updated: Nov 22 2024 at 16:03 UTC