Wasmtime GitHub notifications bot (Apr 22 2024 at 01:45): Wasmtime GitHub notifications bot (Apr 22 2024 at 01:45):jameysharp opened PR #8427 from jameysharp:simplify-x64-i128 to bytecodealliance:main:
Inequality comparisons between i128 values were previously eight instructions and this reduces them to two, plus one move if one of the inputs is still live afterward.
Equality comparisons were six instructions and are now three, plus up to two moves if both inputs are still live afterward.
This removes 45 instructions from the test in x64/i128.clif that generates all possible i128 comparisons. In addition to using fewer instructions for each comparison, it also reduces register pressure enough that the function no longer spills.
Conditional branches on i128 values are a special case but similar optimizations shrink them from six instructions to two.
This brings Cranelift in line with what rustc+LLVM generates for equivalent 128-bit comparisons.
This PR probably conflicts with #8421 in the filetest output; I'll rebase whichever one doesn't land first.
Wasmtime GitHub notifications bot (Apr 22 2024 at 01:45):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8427.
Wasmtime GitHub notifications bot (Apr 22 2024 at 01:45):jameysharp requested fitzgen for a review on PR #8427.
Wasmtime GitHub notifications bot (Apr 22 2024 at 19:23):fitzgen submitted PR review:
Do we cover this in run tests and/or the fuzzer? Seems like a good time to double check that we do.
Wasmtime GitHub notifications bot (Apr 22 2024 at 19:47):jameysharp commented on PR #8427:
We do cover this in runtests, and I know this because I got it wrong several times in ways that the runtests caught. :grin:
I think we also cover it in the Cranelift fuzz targets but I don't remember for sure.
Wasmtime GitHub notifications bot (Apr 22 2024 at 20:25):jameysharp merged PR #8427.
Last updated: Oct 23 2024 at 20:03 UTC