Stream: git-wasmtime

Topic: wasmtime / PR #8425 winch(aarch64): abs, ceil, floor, nea...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 19:01):

evacchi opened PR #8425 from evacchi:winch-morefpu to bytecodealliance:main:

Adds a few more float instructions abs, neg, sqrt and all roundings (ceil, floor, nearest, trunc).

I skipped copysign for now, as it is less trivial and we probably want to port the same logic from cranelift :p

Temporarily submitting as draft because I want to double-check the test cases.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 19:44):

github-actions[bot] commented on PR #8425:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 23 2024 at 12:45):

saulecabrera submitted PR review:

The general direction looks good to me, thanks! I'll give it a more in depth review once it's marked as ready.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi has marked PR #8425 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi requested abrown for a review on PR #8425.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi requested wasmtime-compiler-reviewers for a review on PR #8425.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi requested alexcrichton for a review on PR #8425.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi requested wasmtime-core-reviewers for a review on PR #8425.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 08:41):

evacchi commented on PR #8425:

I think it should be good to go

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 12:03):

alexcrichton requested saulecabrera for a review on PR #8425.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 12:57):

saulecabrera submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 26 2024 at 13:21):

saulecabrera merged PR #8425.

Last updated: Dec 23 2024 at 13:07 UTC