Stream: git-wasmtime

Topic: wasmtime / PR #8423 cranelift/codegen: move `get_isle_com...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:06):

mmcloughlin opened PR #8423 from mmcloughlin:meta-isle-compilations to bytecodealliance:main:

This PR moves the get_isle_compilations function from the codegen build.rs into
the meta crate.

The purpose of this change is to enable sharing the ISLE compilations configuration with
other ISLE tooling.

Note this also makes a minor change that get_isle_compilations does not query the
current directory itself, instead expecting the caller to do it and pass in appropriate
full paths.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:06):

mmcloughlin requested cfallin for a review on PR #8423.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:06):

mmcloughlin requested wasmtime-compiler-reviewers for a review on PR #8423.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 23:10):

cfallin submitted PR review:

Seems reasonable; LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 23:33):

cfallin merged PR #8423.

Last updated: Nov 22 2024 at 16:03 UTC