Stream: git-wasmtime

Topic: wasmtime / PR #8422 Fix handling of large branch values i...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 11:29):

bjorn3 opened PR #8422 from bjorn3:fix_switch_u128_handling to bytecodealliance:main:

Previously trying to branch on a i128 with a branch value larger than i64::MAX after truncating to u64 would result in the branch value incorrectly getting interpreted as a value with the upper 64 bits being 1 rather than 0.

Fixes https://github.com/rust-lang/rustc_codegen_cranelift/issues/1484

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 11:29):

bjorn3 requested elliottt for a review on PR #8422.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 11:29):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #8422.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:08):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:08):

elliottt created PR review comment:

This assert/conversion combination is a little surprising. If y converts to u64, doesn't that mean that there's a possibility that it would produce a negative i64 value?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:14):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 20 2024 at 17:14):

bjorn3 created PR review comment:

A negative i64 here is fine as the value on which we are operating is at most a 64bit integer and thus no implicit sign extension of the immediate will be done by icmp_imm.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 22:40):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2024 at 23:03):

elliottt merged PR #8422.

Last updated: Dec 23 2024 at 13:07 UTC