Stream: git-wasmtime

Topic: wasmtime / PR #8410 Fix use-after-free in externref example

Wasmtime GitHub notifications bot (Apr 19 2024 at 04:04):

alexcrichton opened PR #8410 from alexcrichton:fix-externref-use-after-free to bytecodealliance:main:

This fixes a typo in the externref.c example where a deallocated wasmtime_val_t was used by accident. Additionally this introduces scoping to prevent this from arising again.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 19 2024 at 04:04):

alexcrichton requested fitzgen for a review on PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 04:04):

alexcrichton requested wasmtime-core-reviewers for a review on PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 14:28):

alexcrichton updated PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 14:35):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 19 2024 at 14:35):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 19 2024 at 14:35):

fitzgen created PR review comment:

This is now declared inside this block, but then reused in the other block and has wasmtime_val_delete called outside of the block. Can we move it up, out of this block then?

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:24):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:24):

alexcrichton created PR review comment:

Wait what how does this compile given this mistake...

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:26):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:26):

alexcrichton created PR review comment:

Ah the answer is that it doesn't...

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:27):

alexcrichton updated PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 15:30):

alexcrichton has enabled auto merge for PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 16:05):

alexcrichton merged PR #8410.

Wasmtime GitHub notifications bot (Apr 19 2024 at 16:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 19 2024 at 16:10):

fitzgen created PR review comment:

lol yeah I was wondering myself

Last updated: Oct 23 2024 at 20:03 UTC