Wasmtime GitHub notifications bot (Apr 18 2024 at 23:08): Wasmtime GitHub notifications bot (Apr 18 2024 at 23:08):elliottt opened PR #8405 from elliottt:trevor/tail-callee-saves-riscv64 to bytecodealliance:main:
Switch to using the same set of callee saved registers as the default calling convention on riscv64. This also introduces the contraint that indirect tail calls store their destination in x5, which was an assumption of indirect calls before, but not indirect return calls.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 18 2024 at 23:08):elliottt requested cfallin for a review on PR #8405.
Wasmtime GitHub notifications bot (Apr 18 2024 at 23:08):elliottt requested wasmtime-compiler-reviewers for a review on PR #8405.
Wasmtime GitHub notifications bot (Apr 18 2024 at 23:41):elliottt requested jameysharp for a review on PR #8405.
Wasmtime GitHub notifications bot (Apr 19 2024 at 00:31):elliottt edited PR #8405:
Switch to using the same set of callee saved registers as the default calling convention on riscv64. This also introduces the contraint that indirect tail calls store their destination in
t0, which was an assumption of indirect calls before, but not indirect return calls.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 19 2024 at 00:31):elliottt updated PR #8405.
Wasmtime GitHub notifications bot (Apr 19 2024 at 00:41):jameysharp submitted PR review:
I believe this is correct for the same reasons as similar changes to aarch64, as discussed in https://github.com/bytecodealliance/wasmtime/pull/8406#pullrequestreview-2010186633.
Wasmtime GitHub notifications bot (Apr 19 2024 at 02:04):elliottt merged PR #8405.
Last updated: Jan 10 2026 at 02:36 UTC