fitzgen opened PR #8404 from fitzgen:rec-groups-in-type-registry
to bytecodealliance:main
:
This adds support for recursion groups in Wasmtime's type registry, but still just for function types. Adding struct and array types should be relatively easy after this. At least, we won't have to be concerned with canonicalization, just updating heap type matching everywhere and all that.
Depends on https://github.com/bytecodealliance/wasm-tools/pull/1506 and updating the
wasm-tools
crates before this can land.
fitzgen requested wasmtime-compiler-reviewers for a review on PR #8404.
fitzgen requested abrown for a review on PR #8404.
fitzgen requested wasmtime-core-reviewers for a review on PR #8404.
fitzgen requested wasmtime-default-reviewers for a review on PR #8404.
fitzgen requested alexcrichton for a review on PR #8404.
github-actions[bot] commented on PR #8404:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "cranelift", "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
alexcrichton submitted PR review.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
!!!!1!!11!!
fitzgen submitted PR review.
fitzgen created PR review comment:
:exclamation:
fitzgen updated PR #8404.
fitzgen updated PR #8404.
fitzgen has enabled auto merge for PR #8404.
fitzgen updated PR #8404.
fitzgen merged PR #8404.
Last updated: Nov 22 2024 at 16:03 UTC