Wasmtime GitHub notifications bot (Apr 17 2024 at 21:54): Wasmtime GitHub notifications bot (Apr 17 2024 at 21:54):elliottt edited PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 21:55):elliottt edited PR #8396:
Move doctests out of individual tests by shadowing
rustdocwhen running./ci/run-tests.sh, and explicitly run doctests only in their own dedicated job on anubuntu-latestrunner.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 17 2024 at 21:56):elliottt updated PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 21:57):elliottt updated PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 22:29):elliottt updated PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 22:36):elliottt updated PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 23:00):elliottt updated PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 23:25):elliottt closed without merge PR #8396.
Wasmtime GitHub notifications bot (Apr 17 2024 at 23:25):elliottt commented on PR #8396:
OK, I've also concluded that it's not worth merging just the change to move the doctests out to a separate job, as it would only speed up CI on branches by about 2 minutes, and would have no effect on total merge time on main. It has the additional downside of ignoring any
doctest = falsesettings in any Cargo.toml file, ascargo test --docunconditionally runs doctests.
Last updated: Oct 23 2024 at 20:03 UTC