Stream: git-wasmtime

Topic: wasmtime / PR #8385 Ensure that indirect tail calls on x6...

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:26):

elliottt opened PR #8385 from elliottt:trevor/x64-return-call-indirect-bug to bytecodealliance:main:

When we changed how return_call is handled during instruction emission, we assumed that r11 would always be safe to use as it's a caller-save register on x64. However, this also means that it's available to RA2 for allocation, and could end up holding the destination of a return_call_indirect. To fix this, I've added a temporary writable register to the x64 ReturnCallInfo structure, and marked it with an early def constraint to ensure that it won't conflict with the destination of an indirect call.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:26):

elliottt requested abrown for a review on PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:26):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:27):

elliottt requested alexcrichton for a review on PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:27):

elliottt requested jameysharp for a review on PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:34):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:39):

elliottt updated PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:42):

elliottt updated PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:44):

elliottt updated PR #8385.

Wasmtime GitHub notifications bot (Apr 16 2024 at 18:45):

jameysharp submitted PR review:

Looks great, thank you!

Wasmtime GitHub notifications bot (Apr 16 2024 at 19:52):

elliottt merged PR #8385.

Last updated: Dec 23 2024 at 12:05 UTC