Stream: git-wasmtime

Topic: wasmtime / PR #8378 cranelift/PCC: Only process real addr...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2024 at 01:08):

jameysharp requested cfallin for a review on PR #8378.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2024 at 01:08):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8378.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2024 at 01:08):

jameysharp opened PR #8378 from jameysharp:x64-pcc-check-addr to bytecodealliance:main:

The compute_addr helper only works on real address modes, and one of its callers checks that it only passes a real address mode to it. On x64 we have different Rust types for address modes which are real versus synthetic, so we can simplify a little by reflecting this requirement in the types.

cc: @elliottt

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2024 at 04:16):

cfallin submitted PR review:

Nice simplification, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2024 at 20:53):

jameysharp commented on PR #8378:

If I'm reading CI logs correctly, I think the async_::preview2_ip_name_lookup test timed out, so I think the CI failure was a transient flake. Re-submitting without changes in hopes that it'll work this time.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 17 2024 at 21:15):

jameysharp merged PR #8378.

Last updated: Oct 23 2024 at 20:03 UTC