jameysharp requested cfallin for a review on PR #8378.
jameysharp requested wasmtime-compiler-reviewers for a review on PR #8378.
jameysharp opened PR #8378 from jameysharp:x64-pcc-check-addr
to bytecodealliance:main
:
The
compute_addr
helper only works on real address modes, and one of its callers checks that it only passes a real address mode to it. On x64 we have different Rust types for address modes which are real versus synthetic, so we can simplify a little by reflecting this requirement in the types.cc: @elliottt
cfallin submitted PR review:
Nice simplification, thanks!
jameysharp commented on PR #8378:
If I'm reading CI logs correctly, I think the
async_::preview2_ip_name_lookup
test timed out, so I think the CI failure was a transient flake. Re-submitting without changes in hopes that it'll work this time.
jameysharp merged PR #8378.
Last updated: Dec 23 2024 at 13:07 UTC