Wasmtime GitHub notifications bot (Apr 16 2024 at 00:48): Wasmtime GitHub notifications bot (Apr 16 2024 at 00:48):elliottt opened PR #8377 from elliottt:trevor/tail-calls-aarch64 to bytecodealliance:main:
To mirror the implementation in the x64 backend, switch to eagerly reserving enough space in the incoming argument area for any tail call present in the function being compiled.
Co-authored-by: Jamey Sharp <jsharp@fastly.com>
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 16 2024 at 00:53):elliottt updated PR #8377.
Wasmtime GitHub notifications bot (Apr 16 2024 at 00:55):elliottt updated PR #8377.
Wasmtime GitHub notifications bot (Apr 16 2024 at 00:56):elliottt has marked PR #8377 as ready for review.
Wasmtime GitHub notifications bot (Apr 16 2024 at 00:56):elliottt requested fitzgen for a review on PR #8377.
Wasmtime GitHub notifications bot (Apr 16 2024 at 00:56):elliottt requested wasmtime-compiler-reviewers for a review on PR #8377.
Wasmtime GitHub notifications bot (Apr 16 2024 at 01:03):github-actions[bot] commented on PR #8377:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 16 2024 at 03:42):elliottt edited PR #8377:
To mirror the implementation in the x64 backend, switch to eagerly reserving enough space in the incoming argument area for any tail call present in the function being compiled.
NOTE: this doesn't make the change to enable callee-save registers with the tail calling convention on aarch64, but that will be a relatively small change following this PR.
Co-authored-by: Jamey Sharp <jsharp@fastly.com>
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:16):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:16):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:16):fitzgen created PR review comment:
This was supposed to be removed, right?
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:46):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:46):elliottt created PR review comment:
Yep, thanks for catching that!
Wasmtime GitHub notifications bot (Apr 16 2024 at 15:47):elliottt updated PR #8377.
Wasmtime GitHub notifications bot (Apr 16 2024 at 17:23):elliottt merged PR #8377.
Last updated: Dec 23 2024 at 12:05 UTC