jameysharp requested elliottt for a review on PR #8376.
jameysharp requested wasmtime-compiler-reviewers for a review on PR #8376.
jameysharp opened PR #8376 from jameysharp:simplify-probestack
to bytecodealliance:main
:
Callee::probestack_min_frame
was always set to the guard-page size. That is the same as theguard_size
local ingen_prologue
, which was also the only place which usedprobestack_min_frame
. So don't even bother storing it, just compute it from the flags as needed.Also, remove the long-obsolete
probestack_func_adjusts_sp
setting, which hasn't been used since at least 2021. We may actually want to do something like what that setting described, but even if we do, it should be a choice the backend makes rather than a global setting.
jameysharp requested alexcrichton for a review on PR #8376.
jameysharp requested wasmtime-core-reviewers for a review on PR #8376.
elliottt submitted PR review:
Yay! :tada:
github-actions[bot] commented on PR #8376:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:meta", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
jameysharp merged PR #8376.
Last updated: Dec 23 2024 at 13:07 UTC