elliottt edited PR #8373.
elliottt edited PR #8373:
While working towards running tests with
nextest
, I found that thefiletests
test incranelift-tools
doesn't behave in the way thatnextest
expects. Wrapping it in#[test]
and having it use the test harness fixes this issue.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt requested alexcrichton for a review on PR #8373.
alexcrichton submitted PR review:
I briefly looked into this awhile ago to see if we could actually hook into libtest-mimic and generate a single test per filetests since I think that'd be preferable here, but
cranelift_filetests
has a fair bit of infrastructure which wasn't trivial to disentangle so I abandoned the effort pretty quickly. This seems like a reasonable compromise though.
alexcrichton created PR review comment:
If you're feeling particularly intrepid, this entire block can be deleted now.
alexcrichton submitted PR review:
I briefly looked into this awhile ago to see if we could actually hook into libtest-mimic and generate a single test per filetests since I think that'd be preferable here, but
cranelift_filetests
has a fair bit of infrastructure which wasn't trivial to disentangle so I abandoned the effort pretty quickly. This seems like a reasonable compromise though.
elliottt submitted PR review.
elliottt created PR review comment:
:fire:
elliottt updated PR #8373.
elliottt merged PR #8373.
Last updated: Dec 23 2024 at 12:05 UTC