Stream: git-wasmtime

Topic: wasmtime / PR #8373 Use the test harness for the cranelif...

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:08):

elliottt edited PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:09):

elliottt edited PR #8373:

While working towards running tests with nextest, I found that the filetests test in cranelift-tools doesn't behave in the way that nextest expects. Wrapping it in #[test] and having it use the test harness fixes this issue.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:10):

elliottt requested alexcrichton for a review on PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:11):

alexcrichton submitted PR review:

I briefly looked into this awhile ago to see if we could actually hook into libtest-mimic and generate a single test per filetests since I think that'd be preferable here, but cranelift_filetests has a fair bit of infrastructure which wasn't trivial to disentangle so I abandoned the effort pretty quickly. This seems like a reasonable compromise though.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:11):

alexcrichton created PR review comment:

If you're feeling particularly intrepid, this entire block can be deleted now.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:11):

alexcrichton submitted PR review:

I briefly looked into this awhile ago to see if we could actually hook into libtest-mimic and generate a single test per filetests since I think that'd be preferable here, but cranelift_filetests has a fair bit of infrastructure which wasn't trivial to disentangle so I abandoned the effort pretty quickly. This seems like a reasonable compromise though.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:15):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:15):

elliottt created PR review comment:

:fire:

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:17):

elliottt updated PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 22:45):

elliottt merged PR #8373.

Last updated: Nov 22 2024 at 17:03 UTC