Stream: git-wasmtime

Topic: wasmtime / PR #8373 Use libtest-mimic to make filetests b...

Wasmtime GitHub notifications bot (Apr 15 2024 at 20:58):

elliottt requested cfallin for a review on PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 20:58):

elliottt opened PR #8373 from elliottt:trevor/filetests-libtest-mimic to bytecodealliance:main:

While working towards running tests with nextest, I found that the filetests test in cranelift-tools doesn't behave in the way that nextest expects. Wrapping it with libtest-mimic was enough to get nextest working for that test, but as there's more work to do there, this seemed like a reasonably atomic change to break out.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 15 2024 at 20:58):

elliottt requested wasmtime-default-reviewers for a review on PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 20:58):

elliottt requested wasmtime-compiler-reviewers for a review on PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:00):

elliottt requested alexcrichton for a review on PR #8373.

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:03):

alexcrichton submitted PR review:

For this particular case could #[test] be used? Using libtest-mimic here is basically the same as a single function with #[test] I think

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:06):

elliottt commented on PR #8373:

For this particular case could #[test] be used? Using libtest-mimic here is basically the same as a single function with #[test] I think

Great point, that's totally possible!

Wasmtime GitHub notifications bot (Apr 15 2024 at 21:08):

elliottt updated PR #8373.

Last updated: Nov 22 2024 at 16:03 UTC