elliottt requested cfallin for a review on PR #8373.
elliottt opened PR #8373 from elliottt:trevor/filetests-libtest-mimic
to bytecodealliance:main
:
While working towards running tests with
nextest
, I found that thefiletests
test incranelift-tools
doesn't behave in the way thatnextest
expects. Wrapping it withlibtest-mimic
was enough to getnextest
working for that test, but as there's more work to do there, this seemed like a reasonably atomic change to break out.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt requested wasmtime-default-reviewers for a review on PR #8373.
elliottt requested wasmtime-compiler-reviewers for a review on PR #8373.
elliottt requested alexcrichton for a review on PR #8373.
alexcrichton submitted PR review:
For this particular case could
#[test]
be used? Using libtest-mimic here is basically the same as a single function with#[test]
I think
elliottt commented on PR #8373:
For this particular case could
#[test]
be used? Using libtest-mimic here is basically the same as a single function with#[test]
I thinkGreat point, that's totally possible!
elliottt updated PR #8373.
Last updated: Dec 23 2024 at 12:05 UTC