Wasmtime GitHub notifications bot (Apr 15 2024 at 20:43): Wasmtime GitHub notifications bot (Apr 15 2024 at 20:43):Jakersnell requested wasmtime-compiler-reviewers for a review on PR #8372.
Wasmtime GitHub notifications bot (Apr 15 2024 at 20:43):Jakersnell requested abrown for a review on PR #8372.
Wasmtime GitHub notifications bot (Apr 15 2024 at 20:43):Jakersnell opened PR #8372 from Jakersnell:patch-1 to bytecodealliance:main:
Update C example function for correct formatting. This is useful as the function return type and function signature were on separate lines, which appeared to be an error as this is not how C functions are commonly formatted.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 16 2024 at 09:09):abrown submitted PR review:
Thanks for the PR. I'm not sure what error you were seeing (I think both versions are valid C) but let's go with this becasue "return types on the same line" might be a bit more conventional.
Wasmtime GitHub notifications bot (Apr 16 2024 at 09:32):abrown merged PR #8372.
Last updated: Nov 22 2024 at 17:03 UTC