Stream: git-wasmtime

Topic: wasmtime / PR #8371 Error when `wasmtime::component::bind...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2024 at 17:02):

rylev opened PR #8371 from rylev:error-on-ununsed-with to bytecodealliance:main:

Instead of silently dropping unused with parameters on the floor, we instead error letting the user know that this option is being ignored.

I don't believe there's scaffolding for testing errors produced by the bindgen! macro, so I'm not sure if this can currently be tested.

Fixes https://github.com/bytecodealliance/wasmtime/issues/8304

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2024 at 17:02):

rylev requested alexcrichton for a review on PR #8371.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2024 at 17:02):

rylev requested wasmtime-core-reviewers for a review on PR #8371.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2024 at 18:08):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2024 at 18:31):

alexcrichton merged PR #8371.

Last updated: Nov 22 2024 at 17:03 UTC