Wasmtime GitHub notifications bot (Apr 14 2024 at 18:59): Wasmtime GitHub notifications bot (Apr 14 2024 at 18:59):alexcrichton opened PR #8366 from alexcrichton:fixup-sharedmemory-header to bytecodealliance:main:
- Don't declare an anonymous
struct wasmtime_sharedmemory, instead#includethe actual definition.- Fix an issue where a header in
sharedmemory.hreferred to a type inextern.hwhich wasn't#include'd. This function,wasmtime_sharedmemory_into_extern, additionally isn't necessary as it's no different than manually constructing it. Fix this by removing this function.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 14 2024 at 18:59):alexcrichton requested fitzgen for a review on PR #8366.
Wasmtime GitHub notifications bot (Apr 14 2024 at 18:59):alexcrichton requested wasmtime-core-reviewers for a review on PR #8366.
Wasmtime GitHub notifications bot (Apr 14 2024 at 19:11):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 14 2024 at 19:47):alexcrichton updated PR #8366.
Wasmtime GitHub notifications bot (Apr 14 2024 at 19:47):alexcrichton has enabled auto merge for PR #8366.
Wasmtime GitHub notifications bot (Apr 14 2024 at 19:49):github-actions[bot] commented on PR #8366:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:c-api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 14 2024 at 20:30):alexcrichton merged PR #8366.
Last updated: Oct 23 2024 at 20:03 UTC