Wasmtime GitHub notifications bot (Apr 13 2024 at 00:44): Wasmtime GitHub notifications bot (Apr 13 2024 at 00:44):alexcrichton opened PR #8355 from alexcrichton:fix-gc-ref-count to bytecodealliance:main:
In addition to excluding i31 also exclude funcrefs.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 13 2024 at 00:44):alexcrichton requested fitzgen for a review on PR #8355.
Wasmtime GitHub notifications bot (Apr 13 2024 at 00:44):alexcrichton requested wasmtime-core-reviewers for a review on PR #8355.
Wasmtime GitHub notifications bot (Apr 13 2024 at 00:45):alexcrichton commented on PR #8355:
This was found updating https://github.com/bytecodealliance/wasmtime-cpp to the latest Wasmtime where a test was failing in Rust erroneously for using funcref which caused an error to be returned from a
Store.
Wasmtime GitHub notifications bot (Apr 13 2024 at 00:48):alexcrichton updated PR #8355.
Wasmtime GitHub notifications bot (Apr 13 2024 at 18:08):fitzgen submitted PR review:
r=me with suggestion below
Wasmtime GitHub notifications bot (Apr 13 2024 at 18:08):fitzgen submitted PR review:
r=me with suggestion below
Wasmtime GitHub notifications bot (Apr 13 2024 at 18:08):fitzgen created PR review comment:
We can reuse this helper here:
.filter(|r| r.is_gc_heap_type())(and above)
Wasmtime GitHub notifications bot (Apr 13 2024 at 18:37):alexcrichton updated PR #8355.
Wasmtime GitHub notifications bot (Apr 13 2024 at 18:37):alexcrichton has enabled auto merge for PR #8355.
Wasmtime GitHub notifications bot (Apr 13 2024 at 19:15):alexcrichton merged PR #8355.
Last updated: Dec 23 2024 at 12:05 UTC