Wasmtime GitHub notifications bot (Apr 12 2024 at 22:22): Wasmtime GitHub notifications bot (Apr 12 2024 at 22:22):alexcrichton opened PR #8354 from alexcrichton:faster-tests to bytecodealliance:main:
Currently we've got a good number of WASI tests and they're all relatively large. We also can run a single test in up to three configurations:
- As-is with a module
- As a component in "sync" mode
- As a component in "async" mode
In debug mode compilation of all these modules can take a significant chunk of time (20-30s in total for test suites) This commit updates these test suites to use an in-memory per-process incremental cache backed by a simple
Mutex<HashMap>. This gives some good speedups in debug mode, locally the wasi-common, wasmtime-wasi, and wasmtime-wasi-http test suites were reduced from 32 to 17 seconds. I'd expect larger speedups on less-parallel machines such as our CI.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:22):alexcrichton requested fitzgen for a review on PR #8354.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:22):alexcrichton requested wasmtime-core-reviewers for a review on PR #8354.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:22):alexcrichton requested wasmtime-default-reviewers for a review on PR #8354.
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:09):elliottt submitted PR review:
Looks great!
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:52):alexcrichton merged PR #8354.
Last updated: Nov 22 2024 at 16:03 UTC