Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10): Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10):alexcrichton requested wasmtime-core-reviewers for a review on PR #8353.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10):alexcrichton requested fitzgen for a review on PR #8353.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10):alexcrichton opened PR #8353 from alexcrichton:run-tests to bytecodealliance:main:
Turns out we haven't been running wasi-common tests for some time in CI and they've started failing. Force enable the test at all times and then fix the test failures. The test failures here were introduced in #8277 and weren't caught due to the test not running and the fix was to relax the implementation of
fd_preadto avoid taking multiple mutable borrows.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10):alexcrichton requested wasmtime-default-reviewers for a review on PR #8353.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:56):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:15):alexcrichton updated PR #8353.
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:19):alexcrichton has enabled auto merge for PR #8353.
Wasmtime GitHub notifications bot (Apr 13 2024 at 00:00):alexcrichton merged PR #8353.
Last updated: Dec 23 2024 at 12:05 UTC