Wasmtime GitHub notifications bot (Apr 12 2024 at 22:08): Wasmtime GitHub notifications bot (Apr 12 2024 at 22:08):elliottt opened PR #8352 from elliottt:trevor/cmake-separate-job to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:10):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:12):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:12):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:18):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:23):alexcrichton commented on PR #8352:
I'd recommend adding
prtest:fullto make sure this passes CI (and/or a dummy commit to modify the C API to ensure that the filter still works).Also can you add the new job as a dependency of the "join node" at the bottom of the workflow?
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:27):elliottt edited PR #8352:
We're less constrained for action runners these days, so let's build the c-api tests in parallel with other tests. This cuts out build time for PRs that don't touch the c api, and exploits parallelism for shorter-overall merges to main.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:28):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:28):elliottt has marked PR #8352 as ready for review.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:28):elliottt requested wasmtime-default-reviewers for a review on PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:28):elliottt requested cfallin for a review on PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:31):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:43):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:45):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:47):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:50):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:51):elliottt updated PR #8352.
Wasmtime GitHub notifications bot (Apr 12 2024 at 22:55):elliottt edited PR #8352:
We're less constrained for action runners these days, so let's build the c-api tests in parallel with other tests. This cuts out build time for PRs that don't touch the c api, and exploits parallelism for shorter-overall merges to main.
One effect of this change is that we're no longer building the c-api changes when testing on Qemu, but we are still testing on linux, windows, and macos.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:16):elliottt edited PR #8352:
We're less constrained for action runners these days, so let's build the c-api tests in parallel with other tests. This shortens the long-pole for tests that are required for a merge to main, as well as ci time for PRs that touch the c-api.
One effect of this change is that we're no longer building the c-api changes when testing on Qemu, but we are still testing on linux, windows, and macos.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:21):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 12 2024 at 23:52):alexcrichton merged PR #8352.
Last updated: Nov 22 2024 at 16:03 UTC