Stream: git-wasmtime

Topic: wasmtime / PR #8349 Move `VMSharedTypeIndex` to the `wasm...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):

fitzgen requested alexcrichton for a review on PR #8349.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):

fitzgen requested wasmtime-core-reviewers for a review on PR #8349.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):

fitzgen opened PR #8349 from fitzgen:move-vm-shared-type-index to bytecodealliance:main:

Previously, wasmtime_types::EngineOrModuleTypeIndex had a raw u32 for its engine-level-canonicalized variant. This change allows it to store a VMSharedTypeIndex directly, giving us some additional static assurance that we aren't messing up our different index types and lets us remove a ton of conversions back and forth between raw u32s and VMSharedTypeIndex.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:13):

fitzgen updated PR #8349.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:15):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:44):

github-actions[bot] commented on PR #8349:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 19:19):

fitzgen merged PR #8349.


Last updated: Dec 23 2024 at 12:05 UTC