Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07): Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):fitzgen requested alexcrichton for a review on PR #8349.
Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):fitzgen requested wasmtime-core-reviewers for a review on PR #8349.
Wasmtime GitHub notifications bot (Apr 12 2024 at 18:07):fitzgen opened PR #8349 from fitzgen:move-vm-shared-type-index to bytecodealliance:main:
Previously,
wasmtime_types::EngineOrModuleTypeIndexhad a rawu32for its engine-level-canonicalized variant. This change allows it to store aVMSharedTypeIndexdirectly, giving us some additional static assurance that we aren't messing up our different index types and lets us remove a ton of conversions back and forth between rawu32s andVMSharedTypeIndex.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 12 2024 at 18:13):fitzgen updated PR #8349.
Wasmtime GitHub notifications bot (Apr 12 2024 at 18:15):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Apr 12 2024 at 18:44):github-actions[bot] commented on PR #8349:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 12 2024 at 19:19):fitzgen merged PR #8349.
Last updated: Nov 22 2024 at 17:03 UTC