Stream: git-wasmtime

Topic: wasmtime / PR #8346 `wasmtime-c-api`: Add support for GC ...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 00:05):

fitzgen requested alexcrichton for a review on PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 00:05):

fitzgen opened PR #8346 from fitzgen:gc-refs-in-wasmtime-extension-to-c-api-again to bytecodealliance:main:

Builds on top of https://github.com/bytecodealliance/wasmtime/pull/8344

Restores support for externref in wasmtime_val_t, methods for manipulating them and getting their wrapped host data, and examples/tests for these things.

Additionally adds support for anyref in wasmtime_val_t, clone/delete methods similar to those for externref, and a few i31ref-specific methods. Also adds C and Rust example / test for working with anyref.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 00:05):

fitzgen requested wasmtime-core-reviewers for a review on PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 00:08):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 01:03):

github-actions[bot] commented on PR #8346:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 04:03):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 16:04):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:24):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:24):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 18:24):

alexcrichton created PR review comment:

Mind adding a comment here as to what the ManuallyDrop is doing? It seems related to the destructor of wasmtime_val_t but I couldn't quite figure it out

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 19:02):

fitzgen created PR review comment:

This is a leftover from the old externref support, and I don't think we actually need it anymore. I'll remove it.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 19:02):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 19:16):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 19:17):

fitzgen has enabled auto merge for PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:23):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2024 at 20:24):

fitzgen has enabled auto merge for PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2024 at 18:00):

fitzgen updated PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2024 at 18:01):

fitzgen has enabled auto merge for PR #8346.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 13 2024 at 18:44):

fitzgen merged PR #8346.

Last updated: Nov 22 2024 at 17:03 UTC