Stream: git-wasmtime

Topic: wasmtime / PR #8343 Don't gate on `cargo vet` for PRs

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:38):

alexcrichton opened PR #8343 from alexcrichton:do-not-gate-vet to bytecodealliance:main:

Gate the cargo vet step for the merge queue by default but for PRs don't fail the PR's CI and instead allow entering the queue with a failing cargo vet entry. This should help make it easier to land a cargo vet entry on main outside of a PR while not requiring the PR is rebased.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:38):

alexcrichton requested fitzgen for a review on PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:38):

alexcrichton requested wasmtime-default-reviewers for a review on PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:40):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:41):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:43):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:46):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:48):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:53):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:55):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:57):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 21:57):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 22:00):

alexcrichton commented on PR #8343:

Ok I think this is where it's now working. Summary of changes:

• Example failure: d7f3e533fc4a45cfa30bc4eac1fc6ec3ca98c9c3
• Example success: 81e1e8d2bdc36bd7aafbced42661c4f41d920c07

See the "Cargo vet failed on a Pull Request" run.

My thinking here is that with this new setup PRs will have a "Red X" on a job indicating failure but they won't be blocked from entering the merge queue. The job with the "Red X" just kinda sits there and the merge queue doesn't even listen for it. This is done by allowing cargo vet to fail, but only on PRs. The PR-specific dependency job is then what triggers the "Red X" to give a visual indication to reviewers and authors.

Wasmtime GitHub notifications bot (Apr 11 2024 at 22:10):

alexcrichton updated PR #8343.

Wasmtime GitHub notifications bot (Apr 11 2024 at 23:05):

fitzgen submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Apr 12 2024 at 01:23):

fitzgen merged PR #8343.

Last updated: Dec 23 2024 at 12:05 UTC