Wasmtime GitHub notifications bot (Apr 11 2024 at 19:55): Wasmtime GitHub notifications bot (Apr 11 2024 at 19:55):alexcrichton opened PR #8340 from alexcrichton:fixup-opts to bytecodealliance:main:
- Explicitly document why
blocking_modeis being ignored.- Don't write-in-a-loop to doing a partial write and then returning an error.
- Spawn a background read/write when the embedding cannot block the current thread.
- Don't panic on overflows for addition.
- Fix panic on reads with shared memory
Follow-ups to #8303
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Apr 11 2024 at 19:55):alexcrichton requested fitzgen for a review on PR #8340.
Wasmtime GitHub notifications bot (Apr 11 2024 at 19:55):alexcrichton requested wasmtime-core-reviewers for a review on PR #8340.
Wasmtime GitHub notifications bot (Apr 11 2024 at 22:43):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 12 2024 at 01:32):alexcrichton merged PR #8340.
Last updated: Nov 22 2024 at 16:03 UTC