Stream: git-wasmtime

Topic: wasmtime / PR #8332 wasmtime-wasi-http collection of smal...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 17:48):

rylev opened PR #8332 from rylev:wasi-http-refactor to bytecodealliance:main:

This is a collection of refactors of wasmtime-wasi-http in an attempt to make the API slightly easier to use and more documented.

The various refactorings are all small enough that it seems appropriate to batch them into one PR. Each individual commit should be reviewable as a standalone refactor and any of them should be able to be dropped from the PR should there not be consensus that the refactor is appropriate.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 17:48):

rylev requested alexcrichton for a review on PR #8332.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 17:48):

rylev requested wasmtime-core-reviewers for a review on PR #8332.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 17:53):

rylev commented on PR #8332:

CI is failing, but I'm going to wait for an initial review before proceeding with fixing it.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 18:57):

alexcrichton submitted PR review:

Looks like nice cleanups to me :+1:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 20:15):

rylev updated PR #8332.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 20:43):

rylev requested alexcrichton for a review on PR #8332.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2024 at 21:12):

alexcrichton merged PR #8332.


Last updated: Nov 22 2024 at 16:03 UTC