Stream: git-wasmtime

Topic: wasmtime / PR #8320 winch: Refactor the MacroAssembler trait

Wasmtime GitHub notifications bot (Apr 10 2024 at 13:23):

saulecabrera requested cfallin for a review on PR #8320.

Wasmtime GitHub notifications bot (Apr 10 2024 at 13:23):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #8320.

Wasmtime GitHub notifications bot (Apr 10 2024 at 13:23):

saulecabrera opened PR #8320 from saulecabrera:winch-slim-down-masm to bytecodealliance:main:

No new functionality is introduced as part of this change.

This commit introduces a small refactoring of Winch's MacroAssembler trait by removing multiple methods that can be treated in an ISA-indepedent way by relying on the base building blocks already provided by the MacroAssembler. This change simplifies the process of adding support for other backends to Winch.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 10 2024 at 13:23):

saulecabrera requested elliottt for a review on PR #8320.

Wasmtime GitHub notifications bot (Apr 10 2024 at 13:44):

github-actions[bot] commented on PR #8320:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Apr 10 2024 at 17:13):

elliottt submitted PR review:

This is great!

Wasmtime GitHub notifications bot (Apr 10 2024 at 17:42):

saulecabrera merged PR #8320.

Last updated: Dec 23 2024 at 12:05 UTC