Wasmtime GitHub notifications bot (Apr 08 2024 at 18:50): Wasmtime GitHub notifications bot (Apr 08 2024 at 18:50):jameysharp requested elliottt for a review on PR #8316.
Wasmtime GitHub notifications bot (Apr 08 2024 at 18:50):jameysharp opened PR #8316 from jameysharp:untyped-stack-amode to bytecodealliance:main:
Instead of describing how these address modes might be implemented (using a stack or frame pointer, say), describe what they represent. Also, remove the unused type fields from all variants and from
gen_get_stack_addr.The three kinds of stack addresses that we currently need to generate in a target independent way refer to either caller or callee argument areas, or refer to the spill slots and explicit stack slots within the frame.
It is a target-specific implementation detail whether the incoming argument area is indexed relative to the frame pointer, or whether the stack slots are located by tracking a "nominal" stack pointer offset.
So let's not muddy up the target-independent code by using names that refer to these target-specific concepts.
Wasmtime GitHub notifications bot (Apr 08 2024 at 18:50):jameysharp requested wasmtime-compiler-reviewers for a review on PR #8316.
Wasmtime GitHub notifications bot (Apr 08 2024 at 23:12):elliottt submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Apr 09 2024 at 00:54):jameysharp commented on PR #8316:
Looks to me like maybe a flaky test in the preview2 test suite, so I'm going to try re-submitting it and see if it goes through this time.
Wasmtime GitHub notifications bot (Apr 09 2024 at 01:21):jameysharp merged PR #8316.
Last updated: Nov 22 2024 at 16:03 UTC