Stream: git-wasmtime

Topic: wasmtime / PR #8314 Support `.wat` files in the `explore`...

Wasmtime GitHub notifications bot (Apr 08 2024 at 13:46):

adambratschikaye opened PR #8314 from adambratschikaye:abk/explore-wat to bytecodealliance:main:

Many on the wasmtime subcommands work with either .wasm or .wat files, but explore only works with .wasm. This change accepts .wat as well.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 08 2024 at 13:46):

adambratschikaye requested alexcrichton for a review on PR #8314.

Wasmtime GitHub notifications bot (Apr 08 2024 at 13:46):

adambratschikaye requested wasmtime-core-reviewers for a review on PR #8314.

Wasmtime GitHub notifications bot (Apr 08 2024 at 18:44):

fitzgen submitted PR review:

Thanks! One nitpick below before we merge this.

Wasmtime GitHub notifications bot (Apr 08 2024 at 18:44):

fitzgen submitted PR review:

Thanks! One nitpick below before we merge this.

Wasmtime GitHub notifications bot (Apr 08 2024 at 18:44):

fitzgen created PR review comment:

Can you make sure that this also compiles and works for wasm binaries when the wat dependency isn't enabled? Something like the following:

                #[cfg(feature = "wat")]
                let bytes = wat::parse_bytes(bytes).map_err(|mut e| {
                    e.set_path(path);
                    e
                })?;

Wasmtime GitHub notifications bot (Apr 09 2024 at 09:41):

adambratschikaye updated PR #8314.

Wasmtime GitHub notifications bot (Apr 09 2024 at 09:41):

adambratschikaye submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2024 at 09:41):

adambratschikaye created PR review comment:

Sorry I forgot wat was behind a feature. Fixed it now.

Wasmtime GitHub notifications bot (Apr 09 2024 at 13:36):

fitzgen submitted PR review:

Thanks very much!

Wasmtime GitHub notifications bot (Apr 09 2024 at 14:06):

fitzgen merged PR #8314.

Last updated: Nov 22 2024 at 16:03 UTC