adambratschikaye opened PR #8314 from adambratschikaye:abk/explore-wat
to bytecodealliance:main
:
Many on the
wasmtime
subcommands work with either.wasm
or.wat
files, butexplore
only works with.wasm
. This change accepts.wat
as well.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
adambratschikaye requested alexcrichton for a review on PR #8314.
adambratschikaye requested wasmtime-core-reviewers for a review on PR #8314.
fitzgen submitted PR review:
Thanks! One nitpick below before we merge this.
fitzgen submitted PR review:
Thanks! One nitpick below before we merge this.
fitzgen created PR review comment:
Can you make sure that this also compiles and works for wasm binaries when the
wat
dependency isn't enabled? Something like the following:#[cfg(feature = "wat")] let bytes = wat::parse_bytes(bytes).map_err(|mut e| { e.set_path(path); e })?;
adambratschikaye updated PR #8314.
adambratschikaye submitted PR review.
adambratschikaye created PR review comment:
Sorry I forgot
wat
was behind a feature. Fixed it now.
fitzgen submitted PR review:
Thanks very much!
fitzgen merged PR #8314.
Last updated: Dec 23 2024 at 12:05 UTC