Stream: git-wasmtime

Topic: wasmtime / PR #8311 cranelift/riscv64: Remove unused type...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 22:26):

jameysharp requested fitzgen for a review on PR #8311.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 22:26):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #8311.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 22:26):

jameysharp opened PR #8311 from jameysharp:riscv64-untyped to bytecodealliance:main:

This backend copied the general style of the aarch64 backend's address modes but has no use for a type field in address modes. Just delete them.

Between this and #8308, there are no types in target dependent address modes now. The next step is to delete them from the target independent StackAMode as well.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 22:44):

github-actions[bot] commented on PR #8311:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2024 at 22:46):

jameysharp has enabled auto merge for PR #8311.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2024 at 00:03):

afonso360 submitted PR review:

:+1: LGTM! Nice cleanup.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 06 2024 at 00:45):

jameysharp merged PR #8311.

Last updated: Nov 22 2024 at 16:03 UTC